Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from electron:main #3

Open
wants to merge 3,381 commits into
base: main
Choose a base branch
from
Open

[pull] main from electron:main #3

wants to merge 3,381 commits into from

Conversation

pull[bot]
Copy link

@pull pull bot commented Aug 25, 2021

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

@commit-lint
Copy link

commit-lint bot commented Aug 25, 2021

Features

Continuous Integration

Code Refactoring

Chore

Tests

Bug Fixes

Documentation

Contributors

codebytere, dsanders11, ckerr, aiddya, tr2-harada, miniak, zcbenz, brhenrique, erickzhao, wanted002, jkleinsc

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@mergify
Copy link

mergify bot commented Apr 15, 2022

@pull-request-quantifier[bot] is not allowed to run commands

This PR has 137834 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80898 -56936
Percentile : 100%

Total files changed: 2249

Change summary by file extension:
.gitignore : +10 -4
.yml : +3505 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13186 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

2 similar comments

This PR has 137834 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80898 -56936
Percentile : 100%

Total files changed: 2249

Change summary by file extension:
.gitignore : +10 -4
.yml : +3505 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13186 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137834 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80898 -56936
Percentile : 100%

Total files changed: 2249

Change summary by file extension:
.gitignore : +10 -4
.yml : +3505 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13186 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137861 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80925 -56936
Percentile : 100%

Total files changed: 2249

Change summary by file extension:
.gitignore : +10 -4
.yml : +3505 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

8 similar comments

This PR has 137861 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80925 -56936
Percentile : 100%

Total files changed: 2249

Change summary by file extension:
.gitignore : +10 -4
.yml : +3505 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137861 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80925 -56936
Percentile : 100%

Total files changed: 2249

Change summary by file extension:
.gitignore : +10 -4
.yml : +3505 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137861 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80925 -56936
Percentile : 100%

Total files changed: 2249

Change summary by file extension:
.gitignore : +10 -4
.yml : +3505 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137861 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80925 -56936
Percentile : 100%

Total files changed: 2249

Change summary by file extension:
.gitignore : +10 -4
.yml : +3505 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137861 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80925 -56936
Percentile : 100%

Total files changed: 2249

Change summary by file extension:
.gitignore : +10 -4
.yml : +3505 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137861 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80925 -56936
Percentile : 100%

Total files changed: 2249

Change summary by file extension:
.gitignore : +10 -4
.yml : +3505 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137861 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80925 -56936
Percentile : 100%

Total files changed: 2249

Change summary by file extension:
.gitignore : +10 -4
.yml : +3505 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137861 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80925 -56936
Percentile : 100%

Total files changed: 2249

Change summary by file extension:
.gitignore : +10 -4
.yml : +3505 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137868 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80932 -56936
Percentile : 100%

Total files changed: 2250

Change summary by file extension:
.gitignore : +10 -4
.yml : +3512 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

11 similar comments

This PR has 137868 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80932 -56936
Percentile : 100%

Total files changed: 2250

Change summary by file extension:
.gitignore : +10 -4
.yml : +3512 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137868 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80932 -56936
Percentile : 100%

Total files changed: 2250

Change summary by file extension:
.gitignore : +10 -4
.yml : +3512 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137868 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80932 -56936
Percentile : 100%

Total files changed: 2250

Change summary by file extension:
.gitignore : +10 -4
.yml : +3512 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137868 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80932 -56936
Percentile : 100%

Total files changed: 2250

Change summary by file extension:
.gitignore : +10 -4
.yml : +3512 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137868 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80932 -56936
Percentile : 100%

Total files changed: 2250

Change summary by file extension:
.gitignore : +10 -4
.yml : +3512 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137868 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80932 -56936
Percentile : 100%

Total files changed: 2250

Change summary by file extension:
.gitignore : +10 -4
.yml : +3512 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137868 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80932 -56936
Percentile : 100%

Total files changed: 2250

Change summary by file extension:
.gitignore : +10 -4
.yml : +3512 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137868 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80932 -56936
Percentile : 100%

Total files changed: 2250

Change summary by file extension:
.gitignore : +10 -4
.yml : +3512 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137868 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80932 -56936
Percentile : 100%

Total files changed: 2250

Change summary by file extension:
.gitignore : +10 -4
.yml : +3512 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137868 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80932 -56936
Percentile : 100%

Total files changed: 2250

Change summary by file extension:
.gitignore : +10 -4
.yml : +3512 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137868 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80932 -56936
Percentile : 100%

Total files changed: 2250

Change summary by file extension:
.gitignore : +10 -4
.yml : +3512 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

samuelmaddock and others added 30 commits January 20, 2025 09:54
fix: broken OOP printing on macOS/Linux
* 5786874: Change Observer: Fix crash when navigating to new page

https://chromium-review.googlesource.com/c/chromium/src/+/5786874

* 5794141: Change Observer: Fix Get*PermissionGrant crash

https://chromium-review.googlesource.com/c/chromium/src/+/5794141
Bumps [mikefarah/yq](https://github.com/mikefarah/yq) from 4.44.6 to 4.45.1.
- [Release notes](https://github.com/mikefarah/yq/releases)
- [Changelog](https://github.com/mikefarah/yq/blob/master/release_notes.txt)
- [Commits](mikefarah/yq@4839dbb...8bf425b)

---
updated-dependencies:
- dependency-name: mikefarah/yq
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.28.0 to 3.28.1.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@48ab28a...b6a472f)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
#45277)

chore: align clipboard blink::web_pref::WebPreferences with upstream
* fix: webContents.print() with OOP printing

* Update patches/chromium/printing.patch

Co-authored-by: Robo <[email protected]>

---------

Co-authored-by: Robo <[email protected]>
refactor: simplify ParseUserScript()

local variable user_script no longer needed after #43205
…l<string>` (#45270)

refactor: simplify StopTracing() a little by using a string_view instead of an optional<string>

We have compile-time string literals that we're passing to a method
that takes a string_view argument, so we don't need all this extra
optional<string> scaffolding
… ozone/wayland (#45171)

* fix: backport patch to fix systemd unit activation in Chromium

This backports a patch from Chromium, which fixes systemd unit
activation. That is, a globalShortcuts feature that Chromium has
needs to create a systemd unit and rename it properly. Portal's
global shortcuts uses that name afterwards to map the app with
the shortcuts bound. However, there might be a race between
Chromium binding shortcuts and renaming the unit.

This is a first step to add Portal's globalShortcuts to
Electron.

* feat: Support global shortcuts via GlobalShortcutsPortal feature

Chromium has a new feature called GlobalShortcutsPortal. It
allows clients to use Portal's globalShortcuts to register and
listen to shortcuts.

This patches adds necessary bits, which allows Electron to
use that feature.

In order to make it work, one has to add
--enable-features=GlobalShortcutsPortal

Test: tested manually with a sample app.

* docs: add GlobalShortcutsPortal feature to globalShortcuts docs

Electron supports Portal's globalShortcuts API now via Chromium, and Electron
apps can use that in a Wayland session. Update the docs with the required
feature flag that must be passed to be able to use that implementation.
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.5.0 to 4.6.0.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@6f51ac0...65c4c4a)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
fix: potential crash in chrome.tabs.update()
* chore: bump node in DEPS to v22.11.0

* src: move evp stuff to ncrypto

nodejs/node#54911

* crypto: add Date fields for validTo and validFrom

nodejs/node#54159

* module: fix discrepancy between .ts and .js

nodejs/node#54461

* esm: do not interpret "main" as a URL

nodejs/node#55003

* src: modernize likely/unlikely hints

nodejs/node#55155

* chore: update patch indices

* crypto: add validFromDate and validToDate fields to X509Certificate

nodejs/node#54159

* chore: fixup perfetto patch

* fix: clang warning in simdjson

* src: add receiver to fast api callback methods

nodejs/node#54408

* chore: fixup revert patch

* fixup! esm: do not interpret "main" as a URL

* fixup! crypto: add Date fields for validTo and validFrom

* fix: move ArrayBuffer test patch

* src: fixup Error.stackTraceLimit during snapshot building

nodejs/node#55121

* fix: bad rebase

* chore: fixup amaro

* chore: address feedback from review

* src: revert filesystem::path changes

nodejs/node#55015

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <[email protected]>
feat: better logging if Node initialization fails
* build: migrate release builds to GHA

* build: alter CI jobs release script
* docs: Add note about directly exposing Electron APIs in preload

* Implement feedback
* feat: redesign preload APIs

* docs: remove service-worker mentions for now

* fix lint

* remove service-worker ipc code

* add filename

* fix: web preferences preload not included

* fix: missing common init

* fix: preload bundle script error
* chore: bump chromium in DEPS to 134.0.6948.0

* chore: update can_create_window.patch

https://chromium-review.googlesource.com/c/chromium/src/+/6151982

no patch code changes, but had to manually apply due to upstream context shear

* chore: update proxy_config_monitor.patch

no manual changes; patch applied with fuzz 2

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6126219

* chore: update build_add_electron_tracing_category.patch

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6149256

* chore: update adjust_accessibility_ui_for_electron.patch

https://chromium-review.googlesource.com/c/chromium/src/+/6105650

no patch code changes, but had to manually apply due to upstream context shear

* chore: e patches all

* chore: use fully-qualified path for all.gn

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6154997

* chore: do not use a variable when assigning rtc_use_h264

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6154997

* Move GlobalShortcutListenerLinux to //ui/base

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6097375

* [MPArch Guest View] Make WebPreferences queried per frame tree root

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6096390

* [Status Icons] Allow vector resources

https://chromium-review.googlesource.com/c/chromium/src/+/6139403

* [Extensions] Move MatchOriginAsFallbackBehavior to Mojom

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6141793

* Remove StrongAlias::Hasher

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6132291

* Rename text-change and select-change methods and related stuff

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6148816

* [Code Health] Remove stale feature EnableWebUsbOnExtensionServiceWorker

https://chromium-review.googlesource.com/c/chromium/src/+/6115161

* [Extensions Cleanup] Move creation of tab-based ports to factory method

https://chromium-review.googlesource.com/c/chromium/src/+/6143725

* refactor: add StatusIconGtk::SetIcon()

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6139403

copied from chrome/browser/status_icons/status_icon.cc

* refactor: add TrayIconLinux::GetIcon()

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6139403

* chore: update feat_allow_usage_of_sccontentsharingpicker_on_supported_platforms.patch

remove unused filter_ field

* chore: bump chromium in DEPS to 134.0.6950.0

* chore: bump chromium in DEPS to 134.0.6952.0

* chore: bump chromium in DEPS to 134.0.6954.0

* chore: bump chromium in DEPS to 134.0.6956.0

* chore: update Chromium patches

* 6165749: Check scanout support in RenderableGpuMemoryBufferPool | https://chromium-review.googlesource.com/c/chromium/src/+/6165749

* 6106730: [Win] Use DXGI swapchains and DCOMP visuals in software mode | https://chromium-review.googlesource.com/c/chromium/src/+/6106730

* chore: update patches

* chore: bump chromium in DEPS to 134.0.6958.0

* chore: bump chromium in DEPS to 134.0.6960.0

* chore: update chromium patches

* 6168371: Remove extensions GlobalShortcutListener wrapper | https://chromium-review.googlesource.com/c/chromium/src/+/6168371

* chore: update patches

* 6161637: WebUI: Leverage build_webui() in chrome://translate-internals | https://chromium-review.googlesource.com/c/chromium/src/+/6161637

* chore: bump chromium in DEPS to 134.0.6962.0

* 6177329: Remove policy.used_policy_certificates pref on ChromeOS | https://chromium-review.googlesource.com/c/chromium/src/+/6177329

* 6180524: Simplify logic in components/os_crypt/sync/BUILD.gn | https://chromium-review.googlesource.com/c/chromium/src/+/6180524

* 6144831: Enforce --disallow-v8-feature-flag-overrides in the renderer | https://chromium-review.googlesource.com/c/chromium/src/+/6144831

* chore: update patches

* chore: bump chromium in DEPS to 134.0.6964.0

* 6181010: Ensure busy cursor does not show via LaunchWithoutSandbox | https://chromium-review.googlesource.com/c/chromium/src/+/6181010

* chore: update patches

* chore: bump chromium in DEPS to 134.0.6966.0

* 6180598: [api] Remove Reallocate | https://chromium-review.googlesource.com/c/v8/v8/+/6180598

* 6170781: [Refactor] Move UninstallExtension to ExtensionRegistrar. | https://chromium-review.googlesource.com/c/chromium/src/+/6170781

* chore: update filenames.libcxx.gni

* 6168207: cdm: Remove widevine_cdm_version.h | https://chromium-review.googlesource.com/c/chromium/src/+/6168207

* chore: bump chromium in DEPS to 134.0.6968.0

* 6030552: [macOS] Allow using vibrancy with NativeWidgetNSWindowBridge | https://chromium-review.googlesource.com/c/chromium/src/+/6030552

* fix: use explicit copy to replace realloc impl

https://chromium-review.googlesource.com/c/v8/v8/+/6180598
https://issues.chromium.org/issues/331326406

As per recommendation, "File an issue with Node to explicitly copy,because they copy under the hood anyway"

* fixup! 6106730: [Win] Use DXGI swapchains and DCOMP visuals in software mode | https://chromium-review.googlesource.com/c/chromium/src/+/6106730

* fix: undefine win32 StrCat
https://chromium-review.googlesource.com/c/chromium/src/+/6172292

* fix: //device/vr:directx_helpers breaking the build
https://chromium-review.googlesource.com/c/chromium/src/+/6064548

Upstreamed in https://chromium-review.googlesource.com/c/chromium/src/+/6186102

* fix: avoid calling ui::Layer::SetFillsBoundsOpaquely
https://chromium-review.googlesource.com/c/chromium/src/+/6175787

The layer opacity is determined by the background color's alpha value

* fix: build with proprietary_codecs

The explicit setting of rtc_use_h264 is no longer needed since
https://webrtc-review.googlesource.com/c/src/+/62380

* fix: increase empty trace file size threshold

https://chromium-review.googlesource.com/c/chromium/src/+/6176642
Traces now contain a net-constants property to allow them to be converted to a net log.
These contain ~1240 new properties with formatted JSON data.

* fix: node tests missing resource management globals
https://chromium-review.googlesource.com/c/chromium/src/+/6174695

* fixup! fix: use explicit copy to replace realloc impl

* chore: disable focus handling test due to win32/ia32 regression

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <[email protected]>
Co-authored-by: Keeley Hammond <[email protected]>
Co-authored-by: VerteDinde <[email protected]>
Co-authored-by: Samuel Maddock <[email protected]>
Co-authored-by: Samuel Maddock <[email protected]>
* feat: ServiceWorkerMain

* refactor: disconnect remote

* handle version_info_ nullptr case

* initiate finish request when possible and enumerate errors

* explicit name for test method

* oops

* fix: wait for redundant version to stop before destroying

* docs: clarify when undefined is returned

* chore: remove extra semicolons
)

* build: create maintainer task issue template and disable blank issues

* Implement review feedback by @dsanders11

* Rename issue template file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.